Skip to content

[SPE-68] Modified translation keys and added translations inside the module#57

Open
L3RAZ wants to merge 3 commits into
SPE-72/opc-migrationfrom
SPE-68
Open

[SPE-68] Modified translation keys and added translations inside the module#57
L3RAZ wants to merge 3 commits into
SPE-72/opc-migrationfrom
SPE-68

Conversation

@L3RAZ
Copy link
Copy Markdown
Collaborator

@L3RAZ L3RAZ commented Jun 1, 2026

No description provided.

@ps-jarvis
Copy link
Copy Markdown
Collaborator

Hello @L3RAZ!

This is your first pull request on ps_onepagecheckout repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@L3RAZ L3RAZ requested a review from ThbPS June 1, 2026 12:46
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jun 1, 2026
Copy link
Copy Markdown
Collaborator

@ThbPS ThbPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Assisted automated review — 1 finding, including 0 blocking. Please verify before acting.

'%lastname%' => $customer.lastname
]
}
{l s='Connected as' d='Modules.Onepagecheckout.Shop'}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking)

Problem — This now translates only fragments such as "Connected as" and "Sign out" while the link placement, punctuation, and accessible account label stay hardcoded outside the translation key.
Impact — Locales that need a different word order or punctuation can no longer translate the account banner as a natural sentence, and the aria label loses the same full-context control.
Recommendation — Keep the module domain, but restore full sentence keys with placeholders for the linked customer name, account aria label, and sign-out action, then add those sources to the module XLF files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

3 participants